Add a lexer for ARM assembly files #1057
Conversation
|
I see the CI checks failed. I don't think the failures are my fault, as I experienced the same problem with bundler when I first tried to build rouge. I worked around it with "gem install bundler -v 1.15". This is my first ever attempt at Ruby, so I can't really help more than this, sorry! |
|
@bavison Sorry it's taken so long to get onto this :( I've submitted some comments on the code. Hopefully it all makes sense but of course feel free to ask if anything is unclear. I'd also recommend rebasing against the current master. If you do that, Travis will be able to build and perform the CI checks. |
pyrmont
added
author-action
|
Try as I might, I couldn't figure out the syntax for array-of-keywords-as-method. Hope this will do instead. |
pyrmont
added
needs-review
This is for the syntax used by ARM DS-5, Keil, RealView, ADS, SDT, objasm, asasm and aasm toolchains and *not* the same as that shared by GNU AS and Clang's integrated assembler.
…s; handle C preprocessor directives; don't split filespecs as though they are made of symbols and operators
|
@bavison Thank you for all the effort so far! I hope you don't mind but I've taken the liberty of force pushing an update to your branch. I felt bad because I was mistaken about the whole |
pyrmont
added
author-action
|
@pyrmont Thanks very much for all those polishing touches. I've looked through them all and they make sense - lots of handy advanced features that I'll have to remember for future use. In fact, I reckon you've actually improved its capabilties by merging the first two states, because it can now colour labels that are made up partially using variable substitution, for example |
These two preprocessor statements have no parameters, so do not require following spaces.
|
Thanks @bavison :) This was a lot of work but I think it's in pretty good shape now! |
pyrmont
removed
the
author-action
|
Thanks for hand-holding me through the process. Hopefully the other lexers I've submitted have started from closer to their final form as a result! |
|
@bavison Thanks for all the submissions! Always good to see Rogue highlight more languages :) |
This commit adds a lexer for ARM assembly code. This is for the syntax used by ARM DS-5, Keil, RealView, ADS, SDT, objasm, asasm and aasm toolchains and is **not** the same as that shared by GNU AS and Clang's integrated assembler.
This is for the syntax used by ARM DS-5, Keil, RealView, ADS, SDT, objasm, asasm and aasm toolchains, which is not the same as that shared by GNU AS and Clang's integrated assembler.