Update lexer development guide #1145
Conversation
As per the suggestions from @jneen in rouge-ruby#1111, this updates the lexer development guide.
Co-Authored-By: Ashwin Maroli <ashmaroli@users.noreply.github.com>
Co-Authored-By: Ashwin Maroli <ashmaroli@users.noreply.github.com>
Co-Authored-By: Ashwin Maroli <ashmaroli@users.noreply.github.com>
|
Thanks @ashmaroli :) Suggestions incorporated! |
|
In #1089, @MaximeKjaer pointed out that the 'Special Words' section doesn't use a valid reference to the memoised method. |
|
@pyrmont Please clarify your statement above a bit further.. |
|
The "special words" section is also wrong - we generally discourage interpolating into regular expressions like that. |
|
(the example is also valid - the |
|
Thanks @jneen :) Will update and push a new commit. |
|
@ashmaroli Oh, and for context, this was the discussion to which I was referring where the reference is discussed. |
pyrmont
added
author-action
pyrmont
removed
the
author-action
|
|
||
| To see your visual sample, launch Rouge's visual test app by running `bundle | ||
| exec rackup`. You can choose your sample from the complete list by going to | ||
| <http://localhost:9292>. ot have a file extension. To start the test suite, run |
There was a problem hiding this comment.
Great document ! It looks like there is a missing piece of thee sentence here. I'd be happy to send a pull request to fix this but I don't know what you wanted to write.
There was a problem hiding this comment.
Hahahaha, you've got me—I'm not sure! I think this is an errant copy and paste and everything after 'ot' in this paragraph should be deleted.
As per the suggestions from @jneen in #1111, this updates the lexer development guide.