Introduce :detectable? singleton method for lexers #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
reviewed
Jun 2, 2019
pyrmont
added
the
author-action
pyrmont
removed
the
author-action
|
Thank you @pyrmont 😃 |
|
Good addition, I think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
methods(false).include? :detect?frequently is a significant memory-drain as it generates short-lived arrays (of varying size per lexer) only to be immediately swept away by the GC.Instead, cache the result of the expression in the lexer's singleton class on the first evaluation, and send the cached result on subsequent calls from the same lexer class.
Closes #1148