Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping backslash in javascript lexer #1165

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

ashmaroli
Copy link
Contributor

@ashmaroli ashmaroli commented Jun 10, 2019

An attempt to resolve #828

Testing with the following code:

var foo = {
  a: "\test",
  b: "\nest",
  c: "\\test",
  d: "\\nest",
  e: "\\",
  f: "\\"
};

yields:
javascript Visual Test

/cc @fireattack, @pyrmont, @dblessing

@pyrmont pyrmont added needs-review The PR needs to be reviewed author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jun 10, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 10, 2019

@ashmaroli Left a PR on your branch with some suggested fixes!

@pyrmont pyrmont merged commit 62554b7 into rouge-ruby:master Jun 10, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jun 10, 2019
@ashmaroli ashmaroli deleted the js-esc-bslash branch June 19, 2019 05:25
@ghost ghost mentioned this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javascript object with escaped backslash and immediate quote is broken
2 participants