Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warning when checking whether escape is enabled #1174

Merged
merged 1 commit into from
Jun 13, 2019
Merged

fix warning when checking whether escape is enabled #1174

merged 1 commit into from
Jun 13, 2019

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@mojavelinux
Copy link
Contributor Author

We really need to run the test suite in CI with Ruby warnings enabled (-w) so we can catch these.

@pyrmont
Copy link
Contributor

pyrmont commented Jun 12, 2019

@mojavelinux Ha! I was just writing a comment to ask you what the switch was to get these warnings to show up in the test suite :D

@mojavelinux
Copy link
Contributor Author

Look in the Rakefile. It's commented out with a TODO.

We really should aim to get to 0 warnings because Rouge is extremely noisy.

@ashmaroli ashmaroli mentioned this pull request Jun 12, 2019
Merged
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 13, 2019
@pyrmont pyrmont merged commit de91c27 into rouge-ruby:master Jun 13, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojavelinux @pyrmont