Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce 'character class has duplicated range' msgs #1189

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

ashmaroli
Copy link
Contributor

This includes changes from #1177 and #1180. So, of now this is just a demonstration.
Once the above PRs are merged, the relevant changes of this PR will surface with a rebase.

@pyrmont pyrmont added needs-review The PR needs to be reviewed dependent-pr The PR is dependent on other changes being merged and will be reviewed later. and removed needs-review The PR needs to be reviewed labels Jun 16, 2019
@pyrmont pyrmont added needs-review The PR needs to be reviewed and removed dependent-pr The PR is dependent on other changes being merged and will be reviewed later. labels Jun 17, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 17, 2019

@ashmaroli Thanks for making all these changes. They look good to me. The only ones I was a little curious about were the Elixir and Ruby changes that mashed open and closed together and then called squeeze on the result. Does the test suite go down this path, do you know?

@ashmaroli
Copy link
Contributor Author

Does the test suite go down this path, do you know?

I'm guessing that the reason rake throws warnings there is most probably because those lines are invoked during the task..

@ashmaroli
Copy link
Contributor Author

That said, I'd re-confirm against the visual test just to be sure before merging..

@pocke pocke mentioned this pull request Jun 18, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 19, 2019

The Elixir visual sample doesn't appear to include any code that would test this but the Ruby lexer does. I don't see any regressions.

@pyrmont pyrmont merged commit 056070e into rouge-ruby:master Jun 19, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 19, 2019
@ashmaroli ashmaroli deleted the regex-character-class-warnings branch June 19, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants