add a global 'require' option for all modes #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jneen Out of curiosity, did this need arise due to changes shipped in Rouge 3.4.0 or has it been |
|
It has always been present, if one is using custom lexers. There is a way around it but it's difficult. Most users of rouge don't use the CLI, so they won't be affected by this one way or another. Is there a problem? |
jneen
force-pushed
the
feature.cli-require
branch
from
b8a2ded
to
c215813
Compare
added 2 commits
June 24, 2019 17:26
jneen
force-pushed
the
feature.cli-require
branch
from
9633e4f
to
2d7355b
Compare
Nope. I just wanted to be sure that the issue at hand wasn't because of the |
pyrmont
reviewed
Jun 25, 2019
pyrmont
added
the
author-action
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because, for custom extensions (like lexers) to be loaded, rouge itself must be loaded first. So the usual method of
ruby -r <plugin> <binary>won't work becauseRouge::Lexerwill not be available for subclassing.