Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _class and _while keywords to magik lexer #1251

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Add _class and _while keywords to magik lexer #1251

merged 2 commits into from
Jul 9, 2019

Conversation

StevenLooman
Copy link
Contributor

@StevenLooman StevenLooman commented Jul 6, 2019

Add _class and _while keywords to magik lexer. Newer versions of the magik language support these new keywords.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 8, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 8, 2019

@StevenLooman Could you add an example to the visual sample to confirm this is working?

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jul 8, 2019
@StevenLooman
Copy link
Contributor Author

Good point, added.

spec/visual/samples/magik Outdated Show resolved Hide resolved
@pyrmont pyrmont merged commit 8e812be into rouge-ruby:master Jul 9, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 9, 2019
@StevenLooman
Copy link
Contributor Author

StevenLooman commented Jul 9, 2019 via email

@pyrmont
Copy link
Contributor

pyrmont commented Jul 9, 2019

@StevenLooman No worries! Thanks for contributing the PR :)

@StevenLooman StevenLooman deleted the magik-language-keywords branch July 9, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants