Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify HTML visual sample #1265

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jul 19, 2019

The HTML visual sample is mostly unchanged since it was originally written. This PR removes the mostly duplicative code and instead adds a number of tags after the main HTML document. This simplification will assist in future development.

The HTML visual sample is mostly unchanged since it was originally
written. This commit removes the mostly duplicative code and instead
adds a number of tags after the main HTML document. This simplification
will assist in future development.
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 19, 2019
@pyrmont pyrmont merged commit 45da28a into rouge-ruby:master Jul 21, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jul 21, 2019
@pyrmont pyrmont deleted the bugfix.simplify-html-sample branch January 8, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant