Disable line-number selection in HTMLLineTable #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pyrmont Should I add a config option to toggle the inline-css insertion..? |
|
No, I don't think so. As noted in #1275, while I think this is technically a breaking change, substantively it doesn't remove functionality that I think anyone is really going to want. Your proposed solution is fine. Sometimes I'm just too much of a pedant for my own good, that's all :P |
|
I note that this doesn't stop selection of text in Safari; see this five-year-old bug (five!). Personally, I'm happy to merge this. All other browsers handle this in the correct way; this is Safari's fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1274
/cc @jneen