Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicating capture groups in Julia lexer #1292

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jul 31, 2019

Part of the code introduced in #1024 was a pattern including nested capture groups. This was causing text to be duplicated on output. This PR fixes that bug (and closes #1291).

It also simplifies the visual sample for Julia to remove superfluous examples.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 31, 2019
Copy link
Contributor

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@pyrmont pyrmont merged commit a0a0823 into rouge-ruby:master Aug 2, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Aug 2, 2019
@pyrmont pyrmont deleted the bugfix.julia-duplicates branch January 8, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia lexer generates bad text output on mutable struct
2 participants