Kotlin: Highlight the type of a property

[lordcodes]

Highlight the type for a property. E.g. for below highlights 'Boolean' as Name::Class.

val live: Boolean

Fix nested generics. E.g. for below now correctly highlights both instances of 'Array' as Name::Class and Boolean as Name::Class.

private val live: Array<Array<Boolean>>

@pyrmont

[pyrmont]

@lordcodes Apologies for what might be a dense question but is there any connection between highlighting the type of the property and allowing nested generics? Those seem unrelated and better submitted as separate PRs.

[pyrmont]

Oh, and separately, could you add an example to the visual sample to show this working (perhaps simply the code you included in the OP)?

[lordcodes]

@lordcodes Apologies for what might be a dense question but is there any connection between highlighting the type of the property and allowing nested generics? Those seem unrelated and better submitted as separate PRs.

They can be done as separate PRs, as they technically involved separate code changes. However, they are a related concept. The fix for nested generics was within a case that was called from the property rule that was fixed for the other part of the PR. Both are in the property type, so in my opinion are related and best just fixed together.

The nested generic wasn't an issue previously, as the property type wasn't highlighted at all. I.e. the first change meant that change was also needed.

[lordcodes]

Oh, and separately, could you add an example to the visual sample to show this working (perhaps simply the code you included in the OP)?

Both parts can be seen in the visual sample, i.e. they weren't highlighted before and now they are.

[pyrmont]

@lordcodes Roger that on both points. Will just check out and do a sanity check but should be good to merge.

[lordcodes]

@pyrmont Perfect, thanks!