Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the NASM samples #1421

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

bernardosulzbach
Copy link
Contributor

When reviewing #483, I set out to test how complete the NASM support was.

Apparently, an issue with brackets has already been resolved.

Nonetheless, I went ahead and performed some consistency refactorings in the NASM samples (it mixed tabs with spaces, had misaligned comments, missing spaces after commas, and so on). I also added compilation instructions to the lengthier sample as it is interesting to be able to check whether or not it is a working program.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Feb 1, 2020
@pyrmont pyrmont self-assigned this Feb 1, 2020
spec/visual/samples/nasm Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Feb 1, 2020
@pyrmont pyrmont merged commit 5896d00 into rouge-ruby:master Feb 5, 2020
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants