-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi-line links in Markdown #1465
Enable multi-line links in Markdown #1465
Conversation
The markdown standard allows for link text split over multiple lines. This expands the link regex to enable this.
@Ravlen Sorry for the radio silence :( I've been spending time on some other projects but will get back to getting through these soon! |
Don't worry about it! Take your time, I'm in no hurry!
FYI, I updated GitLab's Rouge version to the latest and it's now in
production. The little tweaks we added are working in our markdown files,
and they are looking great! It's been a great first experience for me!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about the whitespace support:
@pyrmont OK, returned it back to the original, so the update only contains the fix for multi-line link text now. I'll update the description. |
@Ravlen Thanks for another fix! |
While Markdown is supposed to alow link text to span multiple lines, the lexer in Rouge did not support it. This commit enables that support.
Fixes #1450
The markdown standard allows for link text split over multiple lines. This expands the
link regex to enable this.
While I was there, I also allowed for a space between links and link references as well, which is allowed in the spec, and added an example to the markdown test for that as well.Edit: Reverted this change, as per discussion.When tested with
rackup
:cc @pyrmont