Add support for slot shorthand syntax to Vue lexer #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavelda2 How does this look to you? I'm lexing it the same way the non-shorthand syntax is handled (see below).
|
|
Yes, this is requested highlighting 👍 . |
|
Thanks @pavelda2! This fix will go out in version 3.18.0 of Rouge. That's scheduled for release on Tuesday 14 April 🎉 |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
As of Vue 2.6.0, it is possible to use a shorthand syntax for specifying slots. To tokenise the syntax correctly, the HTML `:tag` state must be amended to allow a tag's attributes to include the `#` character. This commit makes that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Vue 2.6.0, it is possible to use a shorthand syntax for specifying slots. To tokenise the syntax correctly, the HTML
:tagstate must be amended to allow a tag's attributes to include the#character.This fixes #1479.