Support regular expressions in Terraform lexer #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sashee I'm really sorry for how long this took. I'm afraid it fell off the radar and I only noticed it again today. I think this fixes the problem you described in your issue but please let me know if you spot anything amiss. |
|
@pyrmont, no worries, thanks for looking into this! |
|
@sashee Thanks again for the bug report. The updated version of the lexer will go out as part of Rouge v3.18.0. That's scheduled for release on Tuesday 14 April 😃 |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
In Terraform, an interpolated expression can include a regular expression of the form `"/.../"`. This commit adds rules that identify regular expressions and a state for tokenising these expressions correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Terraform file, an interpolated expression can include a regular expression of the form
"/.../". This PR adds rules that identify regular expressions. It fixes #1304.