Add explicit support for scope resolution operator in C++ lexer #1523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ lexer inherits the majority of its rules from the C lexer. While this approach reduces duplication, it can cause issues where assumptions that are correct in C, cause issues in C++.
One such issue occurs when the scope resolution operator,
::
, is used in acase
statement. The C lexer contains a rule that treats colons in acase
statement as representing the 'end' of that state. While the assumption that a colon would not otherwise occur in acase
statement is correct in C, that is not the case in C++. The scope resolution operator uses two colons and it can occur within acase
statement.This PR creates a new
:case
state in the C++ lexer that uses a negative lookahead to avoid matching a scope resolution operator. A rule matching the scope resolution operator is also prepended to the:statements
state. This fixes #1506.