Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH config highlighting #1543

Merged
merged 3 commits into from
Jun 29, 2020
Merged

SSH config highlighting #1543

merged 3 commits into from
Jun 29, 2020

Conversation

cmbuckley
Copy link
Contributor

@cmbuckley cmbuckley commented Jun 11, 2020 •
edited by pyrmont
Loading

This fixes #870.

@cmbuckley cmbuckley mentioned this pull request Jun 11, 2020
Closed
cmbuckley added a commit to cmbuckley/cmbuckley.github.io that referenced this pull request Jun 11, 2020
@cmbuckley
Remove ssh highlight until it's available in rouge
033c679 
Was working on rouge-ruby/rouge#1543 at the same time.
@pyrmont pyrmont self-assigned this Jun 19, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 19, 2020
@pyrmont pyrmont changed the title SSH config highlighting (fixes #870) SSH config highlighting Jun 19, 2020
pyrmont
pyrmont suggested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! A couple of comments:

spec/lexers/ssh_spec.rb Show resolved Hide resolved
lib/rouge/lexers/ssh.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jun 19, 2020
@pyrmont pyrmont added needs-review The PR needs to be reviewed and removed author-action The PR has been reviewed but action by the author is needed labels Jun 20, 2020
@pyrmont pyrmont merged commit b33aa4e into rouge-ruby:master Jun 29, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jun 29, 2020

@cmbuckley Thanks for this! Merged it in and it will be part of v3.21.0 of Rouge. That's scheduled for release on Tuesday 14 July 🎉

@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 29, 2020
@cmbuckley cmbuckley deleted the ssh branch July 1, 2020 11:00
cmbuckley added a commit to cmbuckley/cmbuckley.github.io that referenced this pull request Oct 3, 2020
@cmbuckley
Add back in ssh highlight
4645012 
This reverts commit 033c679.

github-pages v208 depends on rouge 3.23.0, which includes rouge-ruby/rouge#1543.
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
@cmbuckley @pyrmont @mattt
Add SSH config lexer (rouge-ruby#1543)
e48e911 
This commit adds a lexer for SSH configuration files.

Co-authored-by: Michael Camilleri <mike@inqk.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

@IanLee1521 IanLee1521 IanLee1521 left review comments

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SSH config highlighting
3 participants
@cmbuckley @pyrmont @IanLee1521