Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: support rust float delimiters #1581

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

hugopeixoto
Copy link
Contributor

1_000.0 is a valid float.

1_000.0 is a valid float.
@pyrmont pyrmont self-assigned this Sep 8, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Sep 8, 2020
@pyrmont pyrmont merged commit 6c9d1b7 into rouge-ruby:master Sep 8, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Sep 8, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Sep 8, 2020

Thanks for this! We actually have a release of Rouge coming later today/early tomorrow (depending on your time zone). This will be part of that release :)

@hugopeixoto hugopeixoto deleted the fix.rust-float-delimiters branch September 8, 2020 00:43
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
The Rust lexer does not currently support the use of `_` in floating
point numbers. If the separator comes immedately after the first digit,
Rouge lexes it as an error. This commit fixes that bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants