Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use bundle config set path instead of deprecated --path #1583

Merged
merged 2 commits into from
Oct 13, 2020
Merged

docs: use bundle config set path instead of deprecated --path #1583

merged 2 commits into from
Oct 13, 2020

Conversation

ComFreek
Copy link
Contributor

In particular, bundle says with --path:

$> bundle install --path vendor
[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set path 'vendor'`, and stop using this flag
Fetching gem metadata from http://rubygems.org/.........

...

hugopeixoto
hugopeixoto reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@hugopeixoto hugopeixoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

The whole file seems to be formatted to wrap at 80 characters.
I think the whole paragraph should be reformatted to follow this rule.

@ComFreek
Copy link
Contributor Author

ComFreek commented Oct 6, 2020 •
edited
Loading

@hugopeixoto fixed it. If you catch any more such tiny edits, feel free to make use of the 'allow edits by maintainers' feature 😄

@hugopeixoto
Copy link
Contributor

@hugopeixoto fixed it. If you catch any more such tiny edits, feel free to make use of the 'allow edits by maintainers' feature smile

Thanks for the suggestion, but I'm not a maintainer :p I'm just trying to help by reviewing PRs

@pyrmont
Copy link
Contributor

pyrmont commented Oct 13, 2020

@ComFreek Thanks for this. Will merge in now!

@pyrmont pyrmont merged commit 9cb00d8 into rouge-ruby:master Oct 13, 2020
@ComFreek ComFreek deleted the patch-1 branch October 13, 2020 08:50
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
@ComFreek @mattt
Update documentation to use bundle config set path (rouge-ruby#1583)
f855989 
The documentation recommends the use of the deprecated `--path` flag. This
corrects the documentation to use the recommended `bundle config set path`
command instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugopeixoto hugopeixoto hugopeixoto left review comments

@pyrmont pyrmont pyrmont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ComFreek @hugopeixoto @pyrmont