Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add J lexer #1584

Merged
merged 11 commits into from
Oct 13, 2020
Merged

Add J lexer #1584

merged 11 commits into from
Oct 13, 2020

Conversation

unsigned-wrong-wrong-int
Copy link
Contributor

This adds a lexer for J.

image

@jneen
Copy link
Member

jneen commented Sep 17, 2020

This looks great, thanks for the contribution! I have just a few comments.

lib/rouge/lexers/j.rb Outdated Show resolved Hide resolved
@unsigned-wrong-wrong-int
Copy link
Contributor Author

Thanks for the review! I removed delegate and it works fine :)

I also added some primitives to @primitive_table. (AFAIK there are no further missing primitives.)

@jneen
Copy link
Member

jneen commented Sep 18, 2020

Awesome, looks much better! 👍 from me.

Copy link
Member

@jneen jneen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pyrmont pyrmont merged commit bb35b76 into rouge-ruby:master Oct 13, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Oct 13, 2020

@unsigned-wrong-wrong-int Thanks for the submission! This will go out as part of v3.24.0 of Rouge. That's scheduled for release tonight/tomorrow (depending on your time zone) 🎉

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
This commit adds a lexer for the J language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants