Rust: fix "await" highlight #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"await" is, currently, highlighted as "Name::Property". It should be highlighted as "Keyword" as well as "async".
jneen
approved these changes
Sep 25, 2020
hugopeixoto
approved these changes
Oct 2, 2020
|
@nsfisis Thanks for this! I've merged it into master and it will be part of the v3.24.0 release that's pushed out tonight/tomorrow (depending on your time zone) 🎉 |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
Currently, `await` is tokenised as `Name::Property`. It should be tokenised as `Keyword` in the same way as `async` is tokenised. This commit fixes that mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
awaitis, currently, highlighted asName::Property. It should be highlighted asKeywordas well asasync.Screenshot
The source code below is borrowed from Rust's visual test (
spec/visual/samples/rust).Before
Thankful-eyes theme:
GitHub theme:
Because GitHub theme and some other themes don't highlight "Name::Property" segments,
awaitis displayed as normal text.After
Thankful-eyes theme:
GitHub theme: