js: add a special case for safe navigation #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1591 Previously, the example `${obj?.prop}` would result in a runaway string literal, since the ? would start a ternary expression, and we would lose the stack state that would cause the second ` to terminate the literal. It is possible the handling of ? needs more care in modern javascript.
pyrmont
approved these changes
Oct 13, 2020
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
Previously, the example `${obj?.prop}` would result in a runaway string
literal, since the `?` would start a ternary expression, and Rouge
would lose the stack state causing the second `` ` `` to terminate the
literal. This commit fixes that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1591
Previously, the example
${obj?.prop}would result in a runaway stringliteral, since the ? would start a ternary expression, and we would lose
the stack state that would cause the second ` to terminate the literal.
It is possible the handling of ? needs more care in modern javascript.