Fix errors from new empty regex requirements #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The merging of rouge-ruby#1548 caused issues with two lexers that had been added after the PR was originally submitted. This commit fixes those errors. It also reduces the number of calls to `String#upcase` and `String#downcase` in the Apex lexer (this lexer was updated in rouge-ruby#1548).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #1548 caused some errors in lexers that had been added after the PR was originally submitted.
This commit also reduces the number of times uppercasing and lowercasing is required in the Apex lexer.