Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Dockerfile as an alias for the docker lexer. #1609

Merged
merged 3 commits into from
Oct 17, 2020

Conversation

KonnorRogers
Copy link
Contributor

@KonnorRogers KonnorRogers commented Oct 14, 2020

This allows users use:

```Dockerfile

When specifying a filetype in their markdown.

@jneen
Copy link
Member

jneen commented Oct 14, 2020

Er, are we sure we don't downcase those tags? Maybe we should.

@KonnorRogers
Copy link
Contributor Author

KonnorRogers commented Oct 14, 2020

@jneen i tested it locally on a site I was building. It translates ```Dockerfile to "language-Dockerfile" so it doesn't appear to downcase as far as I can tell.

@jneen
Copy link
Member

jneen commented Oct 14, 2020

Hm. I don't think there is any compelling reason not to downcase it. Let's merge this for now and I'll start an issue to just downcase all tags and aliases transparently.

@jneen
Copy link
Member

jneen commented Oct 14, 2020

(That will have to be in v4, since it might break some code that relies on the "language-*" css classes)

@jneen jneen merged commit d8ef971 into rouge-ruby:master Oct 17, 2020
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
…#1609)

* Update docker.rb

* format: change double quotes to single quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants