Fix single line block comments and scoped variables and functions in JSL lexer #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblessing
added
the
author-action
added 2 commits
January 20, 2021 09:43
use non greedy .*
|
Thanks for your comments @dblessing. I've added some changes. |
|
Seeing no other discussion, I'm merging. Thanks @BenPH |
dblessing
approved these changes
Jan 27, 2021
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
…JSL lexer (rouge-ruby#1663) * fix lexing of one line block comments * better parsing of scoped variables/functions * missing return * add more jsl visual samples * simplify multiline comment rule use non greedy .* Co-authored-by: Ben Peachey Higdon <bpeachey@predictum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following fixes for the JSL lexer:
namespace:my_var