Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-ascii characters in names in Crystal and Ruby #1894

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix non-ascii characters in names in Crystal and Ruby #1894

merged 1 commit into from
Apr 1, 2024

Conversation

kolesar-andras
Copy link
Contributor

Fixes #1893

@tancnle tancnle self-assigned this Dec 2, 2022
@tancnle tancnle added the needs-review The PR needs to be reviewed label Dec 2, 2022
@tancnle tancnle self-requested a review December 2, 2022 23:26
@tancnle tancnle removed their assignment Dec 2, 2022
@tancnle
Copy link
Collaborator

tancnle commented Dec 3, 2022 •
edited
Loading

Thank you for your contribution @kolesar-andras 🙇🏼 . Would it be possible if we could include some non-ASCII characters examples in the visual samples? 🙏🏼

@tancnle tancnle mentioned this pull request Nov 5, 2023
Open
@tancnle tancnle added this pull request to the merge queue Apr 1, 2024
Merged via the queue into rouge-ruby:master with commit f9a174d Apr 1, 2024
@tancnle tancnle mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancnle tancnle Awaiting requested review from tancnle

Assignees
No one assigned
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-ascii characters in names are marked as error in Crystal and Ruby
2 participants
@kolesar-andras @tancnle