WIP: Add snapshot tests for visual samples #1939
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds snapshot tests for visual samples (
spec/visual/samples/*
). It helps contributors to check if their changes cause regressions or not.Examples
Run
rake spec
for my PR #1938:The failure log shows that the PR changes token types of
super
andreturn
in JavaScript.How to work
UPDATE_SNAPSHOTS
environment variable is defined, all snapshots will be updated.spec/__snapshots__/{language}.snap
.TODO