Add missing C++11/14 syntax (binary numbers, time literals, variadic templates) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'll try to find some time to work on supporting all this soon. |
|
For comparison, here is how GitHub highlights the visual sample. |
|
@rongjiecomputer Sorry this has been outstanding for such a long time. I'm not sure if you're still interested, but I've rebased this against the current master and added the missing syntax. I'm not very familiar with C++ so am not sure if this looks like it should; there are no error tokens and it looks to my eyes broadly consistent with GitHub's highlighting. |
pyrmont
added
the
author-action
pyrmont
changed the title
|
@pyrmont looks good! |
pyrmont
removed
the
author-action
|
Well, it took three years and I screwed up the commit message but we did it @rongjiecomputer! Rouge will now be able to kick 3.5% more ass when highlighting C++ :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: binary literal (line 5), time literal (line 20-27) and variadic template (line 81-84, 119) are not highlighted correctly.