Added a simple reprap G-Code parser. #789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidarh
suggested changes
Jan 13, 2019
There was a problem hiding this comment.
Hi, I'm trying to help triage pull requests so we can work down the backlog. Couple of minor nitpicks - see commits on the commits.
One bigger one: Please submit a smaller spec/visual/samples/gcode. The purpose is to have something that includes tests for most of the lexer rules, and since this lexer is this small there really shouldn't be need for something that huge.
| desc 'A generic lexer for reprap/cnc g-code files' | ||
| filenames '*.gco', '*.ngc', '*.gcode', '*.g' | ||
|
|
||
| # short and sweet |
There was a problem hiding this comment.
It is indeed short and sweet, but please remove
| @@ -0,0 +1,28 @@ | |||
| # -*- coding: utf-8 -*- # | |||
|
|
|||
There was a problem hiding this comment.
Please add '# frozen_string_literal: true'
| @@ -0,0 +1,13 @@ | |||
| # -*- coding: utf-8 -*- # | |||
|
|
|||
There was a problem hiding this comment.
Please add '# frozen_string_literal: true'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G-Code is a language used by 3D printers and CNC machines to print/cut stuff. It is a simple text-based language.