Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #796: comments not followed by a newline are not highlighted #797

Merged
merged 5 commits into from Oct 13, 2017

Conversation

tyxchen
Copy link
Contributor

@tyxchen tyxchen commented Oct 7, 2017

A C/C++ one-line comment at the end of a file that is not followed by a newline will not be recognized, as reported in #796.

From the looks of it, the Kotlin, PHP, and Sass/SCSS lexers are also affected. I can include fixes for those lexers in this pull request, or create a new PR just for them if preferred.

@gfx
Copy link
Member

gfx commented Oct 11, 2017

Sounds good. Can you add all the fixes for other languages?

@tyxchen
Copy link
Contributor Author

tyxchen commented Oct 12, 2017

Yup, added.

@gfx
Copy link
Member

gfx commented Oct 13, 2017

Thanks!

@gfx gfx merged commit 0b89c32 into rouge-ruby:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants