Fix highlighting of diff file/date lines #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Richman
commented
Dec 29, 2017
Alex-Richman
commented
- Fix the existing regex for the '---' lines
- Add regex for '+++' lines
- Make both highlight as Generic::Heading rather than text
- Fix the existing regex for the '---' lines - Add regex for '+++' lines - Make both highlight as Generic::Heading rather than text
|
Some examples of the issue here: https://gitlab.com/gitlab-org/gitlab-ce/issues/22962 NB: I haven't tested this and have never written a line of ruby before now ;) |
vidarh
added a commit
to vidarh/rouge
that referenced
this pull request
Jan 18, 2019
Close rouge-ruby#846 as it conflicts and this commit differentiates further.
This was referenced Jan 18, 2019
pyrmont
pushed a commit
to pyrmont/rouge
that referenced
this pull request
May 17, 2019
This fixes rouge-ruby#1022. It also close rouge-ruby#846 as that PR is incompatible with this one.
pyrmont
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.