[Fix #895] allow numbers within variable names #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmr
suggested changes
Apr 18, 2018
|
@fmichonneau I'm sorry it's taken so long to get to this. I also apologise for force pushing to your branch. It's been so long since your submission that Rouge's test suite has evolved quite a bit and I needed to rebase against master to bring that all up to date. I think the regex I've added (described here) now does the trick but please let me know if there's an edge case that's not being properly considered. |
pyrmont
added
author-action
|
Thanks for your help, @klmr! Rouge is a on a two-week cadence for releases as we work our way through the backlog. This fix will come out in v3.8.0 next Tuesday :) |
pyrmont
removed
the
author-action
|
thank you for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #895
This is my first contribution to a Ruby project. Please provide feedback if anything else is needed.
@klmr given that you improved the R lexer, could you please double check that this looks reasonable?