Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow []()*. in html attribute names #725 #907

Merged
merged 4 commits into from
Jul 21, 2019

Conversation

Runinho
Copy link
Contributor

@Runinho Runinho commented May 10, 2018

Fix issue #725
Allow []()*. in Attribute names with values.
Allow #* in Attribute names.

@NEO97online
Copy link

LGTM, is anything holding this up? Would be great for angular2.

@dblessing
Copy link
Collaborator

Thanks @Runinho. Instead of the specs all we need is some examples in spec/visual/samples/html that show this works. I appreciate the sentiment in adding tests, though.

@dblessing dblessing added the author-action The PR has been reviewed but action by the author is needed label Jun 13, 2018
@pyrmont pyrmont added needs-review The PR needs to be reviewed and removed author-action The PR has been reviewed but action by the author is needed labels Jul 18, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 21, 2019

@Runinho I had two apologies:

  1. I'm sorry but I've force pushed to your branch. I've rebased this PR against the current version of master and fixed a couple of things to reflect changes since your original submission.

  2. More generally, I'm sorry it's taken such a long time to get to this. Thank you for taking the time to prepare the request, I think we should be good to merge in very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants