Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing keywords from PHP #973

Merged
merged 7 commits into from
Jul 10, 2019
Merged

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Aug 15, 2018

No description provided.

@pyrmont
Copy link
Contributor

pyrmont commented Jul 3, 2019

@mcfedr I'm sorry it's taken so long to get back to you on this :(

This PR looks really good. Thank you especially for adding tests to the spec. Would you also be able to add a couple of examples using the new keywords to the visual sample? It's in spec/visual/samples/php. That would be very helpful!

@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label Jul 3, 2019
@mcfedr
Copy link
Contributor Author

mcfedr commented Jul 9, 2019

Hi @pyrmont It has been a little while :)

I've added a few more examples, and actually a couple more cases - there is still work to be done to make the samples look as good as they could but I've not got the time right now to work on it.

Also rebased on master, and run the command rake builtins:php to update the builtins as a couple of php releases have changed them a bit.

Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed two errors in the visual test app:

spec/visual/samples/php Show resolved Hide resolved
spec/visual/samples/php Show resolved Hide resolved
@pyrmont pyrmont merged commit 5a0a5f2 into rouge-ruby:master Jul 10, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 10, 2019

@mcfedr Rouge is a better library with a more up to date version of the PHP lexer (and good to fix a tokenisation bug, too!). Thanks for all your help!

We currently have a two-week cadence for minor releases. As it happens, 3.6.0 went out yesterday and so if everything sticks to schedule, this should be available as part of 3.7.0 on Tuesday 23 July.

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 10, 2019
@mcfedr mcfedr deleted the php-missing-keyword branch July 10, 2019 09:10
@mcfedr
Copy link
Contributor Author

mcfedr commented Jul 10, 2019

Awesome, great to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants