Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: Recognise annotations and map to decorator #995

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Kotlin: Recognise annotations and map to decorator #995

merged 2 commits into from
Oct 1, 2018

Conversation

lordcodes
Copy link
Contributor

This matches Java's handling, mapping an annotation like @deprecated to Name::Decorator.

Added example to the visual sample and unit test.

Fixes #994.

This matches Java's handling, mapping an annotation like @deprecated to Name::Decorator.

Added example to the visual sample and unit test.
@lordcodes lordcodes changed the title Recognise annotations and map to decorator Kotlin: Recognise annotations and map to decorator Sep 21, 2018
@lordcodes
Copy link
Contributor Author

lordcodes commented Sep 24, 2018

CC @dblessing

@lordcodes
Copy link
Contributor Author

@jneen Sorry to bump this PR, but would be really keen to get these Kotlin PRs I have put forward included, as currently Rouge is almost unusable for Kotlin as it doesn't really highlight anything other than certain keywords.

spec/lexers/kotlin_spec.rb Outdated Show resolved Hide resolved
@dblessing dblessing added the author-action The PR has been reviewed but action by the author is needed label Oct 1, 2018
@lordcodes
Copy link
Contributor Author

@dblessing Test removed, sample already present. Thanks for review.

@dblessing dblessing merged commit 5565d32 into rouge-ruby:master Oct 1, 2018
@lordcodes lordcodes deleted the kotlin-annotations branch October 1, 2018 15:37
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin: Annotations rendered as regular 'Name'
3 participants