Kotlin - Function names (including generics and extensions) #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Regular function - Extension function - Generic function - Generic Extension function
Put back previous recognition of fun keyword. Using state to recognize instead of long regexes.
Generic and non-generic extension functions
Rather than mapping it to punctuation containing plain text. Map each generic parameter to Name.Class and the less than, greater than and internal commas to punctuation.
|
CC @dblessing |
|
@jneen Sorry to bump this PR, but would be really keen to get these Kotlin PRs I have put forward included, as currently Rouge is almost unusable for Kotlin as it doesn't really highlight anything other than certain keywords. |
dblessing
requested changes
Oct 1, 2018
dblessing
added
the
author-action
|
@dblessing Removed the tests and added missing samples. Thanks for review. |
This was referenced Oct 1, 2018
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize Kotlin function names (declarations).
This includes handling extension functions, generic functions and generic extension functions.
The solution uses state to avoid long regexes.
Includes unit tests for each type.
Fixes #792.
Fixes #791.
Fixes #906.