Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check in init.lua to prevent nil access #33

Closed
wants to merge 2 commits into from

Conversation

JoBoCl
Copy link

@JoBoCl JoBoCl commented Apr 5, 2023

Currently, this is cause the plugin to crash (#32) when running any test.

JoBoCl and others added 2 commits April 5, 2023 18:46
Currently, this is cause the plugin to crash (rouge8#32) when running any test.
Copy link
Owner

@rouge8 rouge8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for when this happens? It sounds like the XML file exists, but maybe no tests were run?

@tuanbass
Copy link

tuanbass commented Sep 13, 2023

Can you add a test for when this happens? It sounds like the XML file exists, but maybe no tests were run?

I ran into the issue today. I create a simple repo to help reproducing the problem at https://github.com/tuanbass/test-ws-rust

open foo/src/lib.rs and try to run the test.

But the fix, while necessary, still does not resolve the root cause. No more crash, but the test was not run.
The root cause seem is occurred when determined the cwd to run cargo nextest command for rust project with workspace enable.
When open such project, the cwd is set to root project's path not the member's one. Hence cargo nextest cannot found any test/test suite.

@tuanbass
Copy link

tuanbass commented Sep 13, 2023

Can you add a test for when this happens? It sounds like the XML file exists, but maybe no tests were run?

After some debug, seem it's set to workspace's root by intention, but I cannot figure out the result behind.
A simple patch fixes the problem with workspace, but I'm not sure whether it causes other problem :lol

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants