Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider onConfigurationChanged. #788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rake-Kharton
Copy link

Purpose

For handling orientation changes.
Before this fix, each of tabs has too small size when the orientaion is changed.

Reproduction steps

  1. Handle the configuration change yourself
<activity android:name=".ThreeTabsActivity"
            android:configChanges="orientation|screenSize"/>
  1. Start sample app with portrait screen orientation and change to landscape

Images

Portrait Landscape
Before before_portrait before_landscape
After Same to portrait orientation's after_landscape

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 63.101% when pulling b7e4ac0 on Rake-Kharton:orientation_changes into 711fcaf on roughike:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants