Ot svg support #174
Merged
Ot svg support #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is as far as it could go - use global _state in svg_init/svg_free, accessing it via the input argument "ctx" as a pointer to a py_object. Conflicts: examples/ot-svg-example.py
|
The global needs to stay at least partially, as otherwise python does not know that the state object kept by the c-side needs to stay around for the next call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works as is. There is a small problem as I haven't figured out how to populate a c pointer from the python side, so the ctx/state is currently a global instead. If I can't figure it out soon I'll probably add a comment about it and just merge as is.