Fix FT_Done_FreeType never being called on FT_Library instance. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if error: raise FT_Exception(error) | ||
|
|
||
| try: | ||
| set_lcd_filter( FT_LCD_FILTER_DEFAULT ) |
There was a problem hiding this comment.
While reading your patch, I wonder why I put this specific initialisation code here. In any case, we should not silence the exception.
|
I agree, also set_lcd_filter It also happens eventually to loop back and call get_handle before _init_freetype() returns. |
|
It was added in this commit: 2fc2636 |
|
Any status on merging? |
|
Sorry for the delay. |
rougier
added a commit
that referenced
this pull request
Feb 15, 2015
Fix FT_Done_FreeType never being called on FT_Library instance.
This was referenced May 30, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 2 the injected del method was called, but by the time FT_Library was deleted the FT_Done_FreeType function was gone. This has been worked around by storing a reference of FT_Done_FreeType.
However under python 3 there was a second issue. For whatever reason the injected del method wasn't called at all. They work on a normal classes and subclasses in python 3, so I'm not completely sure what was going on there. Fixed this by just subclassing FT_Library, and defining the needed stuff in there.
This also has a nice side effect of no longer injecting the del function into the raw FT_Library, which also effected anyone using freetype raw.