Fixed hardcoding of mu4e-dashboard-file in mu4e-dashboard-parse-keymap and added mu4e-dashboard function #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, mu4e-dashboard-mode operates in the current file, but the keymaps are always loaded from the file mu4e-dashboard-file (it silently does nothing if the file does not exist) This means that, when the current file is not mu4e-dashboard-file, the file's keybindings are ignored. This bug is fixed in this commit. Also, a new function is added: mu4e-dashboard, that will visit mu4e-dashboard-file and run mu4e-dashboard-mode on it. It will generate an error if the file does not exist.
|
I found a weird bug. return is redefined in all org files. I have to fix that. @rougier what do you think about having the function mu4e-dashboard? |
Simply moved the local-set-key after the keymap has been redefined
|
I added a commit that fixes setting in all org-mode buffers. It is now only done in the current buffer. |
|
Looks good to me. In fact, I've a mu4e-dashboard function in my own configuration but it makes sense to have a minimal one with the dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mu4e-dashboard-mode operates in the current file, but the keymaps are always
loaded from the file mu4e-dashboard-file (it silently does nothing if the file does
not exist)
This means that, when the current file is not mu4e-dashboard-file, the file's keybindings
are ignored. This bug is fixed in this commit.
Also, a new function is added: mu4e-dashboard, that will visit mu4e-dashboard-file and
run mu4e-dashboard-mode on it. It will generate an error if the file does not exist.