Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework theme autoloading for helm #66

Closed
wants to merge 7 commits into from
Closed

Conversation

ndw
Copy link
Contributor

@ndw ndw commented May 1, 2021

This PR implements a patch proposed by @mclearc to fix problems with autoloading and helm.

@rougier
Copy link
Owner

rougier commented May 3, 2021

Thanks! Can you also add a call to new functions at the end (near helm call)?

@ndw
Copy link
Contributor Author

ndw commented May 3, 2021

Done.

@rougier
Copy link
Owner

rougier commented May 15, 2021

Sorry for the delay. Can you rebase your PR?

@ndw
Copy link
Contributor Author

ndw commented May 15, 2021

Done

@rougier
Copy link
Owner

rougier commented May 15, 2021

Thanks. Maybe I'm missing a point but GitHub still show large changes to be committed. Do you have any idea why it is so?

@ndw
Copy link
Contributor Author

ndw commented May 19, 2021

Replaced by #73.

@ndw ndw closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants