Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New frame background doesn't follow the currently using theme. #14

Closed
chuxubank opened this issue Oct 11, 2021 · 5 comments
Closed

New frame background doesn't follow the currently using theme. #14

chuxubank opened this issue Oct 11, 2021 · 5 comments

Comments

@chuxubank
Copy link

When using make-frame-command within nano-dark-theme, the new frame's background is light.

@pmatos
Copy link

pmatos commented Oct 15, 2021

True - I have just noticed this with mu4e. If I start to compose a new email on a new frame. When the frame opens, it's in light mode. No idea why tbh. @rougier any ideas?

@rougier
Copy link
Owner

rougier commented Oct 18, 2021

Yes, something wrong and this might be related to #12 as well. As a temporary workaround, there is a nano-make-frame command where you can specify the theme. I'm working on it but most probably, I forgot to set something. The theme (dark/light) is supposed to be chosen automatically from the frame background-mode but for newly created frame, there should be some default value somewhere that I need to take into account.

@pmatos
Copy link

pmatos commented Oct 18, 2021

Yes, something wrong and this might be related to #12 as well. As a temporary workaround, there is a nano-make-frame command where you can specify the theme. I'm working on it but most probably, I forgot to set something. The theme (dark/light) is supposed to be chosen automatically from the frame background-mode but for newly created frame, there should be some default value somewhere that I need to take into account.

Thanks for looking into this.

@rougier
Copy link
Owner

rougier commented Oct 18, 2021

I've just pushed a tentative fix

@chuxubank
Copy link
Author

chuxubank commented Oct 18, 2021

Confirm fixed! Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants