Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solution of #66 #142

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Fix solution of #66 #142

merged 2 commits into from
Feb 18, 2021

Conversation

artfintl
Copy link
Contributor

@artfintl artfintl commented Feb 10, 2021

The data type will promote to uint32 as expected.

@rougier
Copy link
Owner

rougier commented Feb 18, 2021

Thanks. I forgot to tell you but it would be better to modify the generator file instead of the output file.

@rougier rougier merged commit 7a830af into rougier:master Feb 18, 2021
@rougier
Copy link
Owner

rougier commented Feb 18, 2021

Thanks !

@rougier
Copy link
Owner

rougier commented Feb 27, 2021

@artfintl I think I merged your PR on the wrong file. Can you modify the generator file instead of the .md ?

Fisher-Wang added a commit to Fisher-Wang/numpy-100 that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants