Implements v2.0.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seultou
suggested changes
Mar 26, 2018
CHANGELOG-2.0.md
Outdated
| * This new version is only for PHP ⩾7.1. | ||
| * Update all dependencies | ||
| * DoctrineParamConverter is not used needed anymore | ||
| * This bundle only convert hashid into an id |
CHANGELOG-2.0.md
Outdated
| * DoctrineParamConverter is not used needed anymore | ||
| * This bundle only convert hashid into an id | ||
| * Replace `autowire` with `passthrough`. | ||
| This new parameter which permits to continue with next param converters available. |
There was a problem hiding this comment.
whitespace between + and This ? or you didn't mean to put a new line ?
There was a problem hiding this comment.
No, it's intended to continue with the previous point.
README.md
Outdated
|
|
||
| Converter Name: `hashids.converter` | ||
|
|
||
| The hashids converter attempts to convert request hashid attributes to a | ||
| id for fetch a Doctrine entity. | ||
| The hashids converter attempts to convert request hashid attributes to an id. |
CHANGELOG-2.0.md
Outdated
| * feature #24583 Adding a new debug:autowiring command (weaverryan) | ||
| * This new version is only for PHP ⩾7.1. | ||
| * Update all dependencies | ||
| * DoctrineParamConverter is not used needed anymore |
README.md
Outdated
| The autowiring subsystem will detect the hashid. | ||
|
|
||
| Base on the example above: | ||
| For specify to use hashids converter just add `"hashid" = "{parameter_name}"` |
|
for |
babaorum
reviewed
Mar 26, 2018
CHANGELOG-2.0.md
Outdated
| * DoctrineParamConverter is not used needed anymore | ||
| * This bundle only convert hashid into an id | ||
| * Replace `autowire` with `passthrough`. | ||
| This new parameter which permits to continue with next param converters available. |
README.md
Outdated
|
|
||
| ## Installation |
There was a problem hiding this comment.
You do not keep a "regular" install ?
Since you specify for symfony flex ...
Maybe just describe the extra steps for symfony flex ....
README.md
Outdated
|
|
||
| Open a command console, enter your project directory and execute the | ||
| following command to download the latest stable version of this bundle: | ||
|
|
||
| ``` | ||
| composer require roukmoute/hashids-bundle | ||
| composer config extra.symfony.allow-contrib true | ||
| composer req roukmoute/hashids-bundle | ||
| ``` | ||
|
|
||
| This command requires you to have Composer installed globally. |
There was a problem hiding this comment.
if you keep it that way, these commands.
seultou
approved these changes
Mar 26, 2018
greg0ire
reviewed
Mar 26, 2018
README.md
Outdated
|
|
||
| Open a command console, enter your project directory and execute the | ||
| following command to download the latest stable version of this bundle: | ||
| Theses commands requires you to have Composer installed globally. |
greg0ire
reviewed
Mar 26, 2018
README.md
Outdated
| Or can directly use `id` now ! | ||
| ## Using Passthrough | ||
|
|
||
| `Passthrough` permits to continue with next param converters available. |
There was a problem hiding this comment.
"permits" => "allows"
"the next available param converters"
greg0ire
reviewed
Mar 26, 2018
CHANGELOG-2.0.md
Outdated
| * DoctrineParamConverter is not used anymore | ||
| * This bundle only converts hashid into an id | ||
| * Replace `autowire` with `passthrough`. | ||
| This new parameter which permits to continue with the next param converters available. |
There was a problem hiding this comment.
"allows to continue with the next available param converters"
babaorum
approved these changes
Mar 26, 2018
Repository owner
deleted a comment from
seultou
Mar 26, 2018
roukmoute
force-pushed
the
v2.0
branch
7 times, most recently
from
3eb2070
to
8d26270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.