Fixed getIdentifier() must be of the type string #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$configuration->getName()
isnull
, which is possible with the default@ParamConverter
fromFrameworkExtraBundle
an exception will be thrown becausegetIdentifier
requires a string as third param.Using
?string $name
is not allowed since the bundle should be compatible with php >= 7.1private function getIdentifier(Request $request, $options, string $name): string