Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getIdentifier() must be of the type string #7

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fixed getIdentifier() must be of the type string #7

merged 1 commit into from
Apr 16, 2019

Conversation

jverdeyen
Copy link
Contributor

When $configuration->getName() is null, which is possible with the default @ParamConverter from FrameworkExtraBundle an exception will be thrown because getIdentifier requires a string as third param.
Using ?string $name is not allowed since the bundle should be compatible with php >= 7.1

private function getIdentifier(Request $request, $options, string $name): string

When `$configuration->getName()` is `null`, which is possible with the default `@ParamConverter` from `FrameworkExtraBundle` an exception will be thrown because `getIdentifier` requires a string as third param. 
Using `?string $name` is not allowed since the bundle should be compatible with php >= 7.1

`private function getIdentifier(Request $request, $options, string $name): string`
@roukmoute roukmoute merged commit 08d249f into roukmoute:master Apr 16, 2019
@roukmoute
Copy link
Owner

Thanks @jverdeyen!

@roukmoute
Copy link
Owner

New release v.2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants