Fix bug where some parts of a message could have been missing in a re…

…ply/forward body (#7568)
roundcube · Aug 30, 2020 · 5264534 · 5264534
1 parent 77bc3f2
commit 5264534
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -51,6 +51,7 @@ CHANGELOG Roundcube Webmail
 - Fix jstz.min.js installation, bump version to 1.0.7
 - Fix link to closure compiler in bin/jsshrink.sh script (#7567)
 - Fix incorrect PDO::lastInsertId() use in sqlsrv driver (#7564)
+- Fix bug where some parts of a message could have been missing in a reply/forward body (#7568)
 
 RELEASE 1.4.8
 -------------

diff --git a/program/lib/Roundcube/rcube_message.php b/program/lib/Roundcube/rcube_message.php
@@ -531,7 +531,7 @@ public function mime_parts()
     public function is_attachment($part)
     {
         foreach ($this->attachments as $att_part) {
-            if ($att_part->mime_id == $part->mime_id) {
+            if ($att_part->mime_id === $part->mime_id) {
                 return true;
             }
 
@@ -586,7 +586,7 @@ private function parse_structure($structure, $recursive = false)
                 list($headers, $body) = explode("\r\n\r\n", $this->get_part_body($structure->mime_id, false, 32768));
                 $structure->headers = rcube_mime::parse_headers($headers);
 
-                if ($this->context == $structure->mime_id) {
+                if ($this->context === $structure->mime_id) {
                     $this->headers = rcube_message_header::from_array($structure->headers);
                 }