Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
The threaded view doesn't is not get bold on unread messages #2817
Reported by mrfrank on 30 Apr 2010 06:54 UTC as Trac ticket #1486701
if there are some read and some unread messages in a threaded view, the collapsed messages will be displayed with the read state of the Message in the highest level(the first message).
Let me give you an example:
Comment by kaz on 10 Aug 2010 15:37 UTC
The UI is confusing because it introduces a different, inconsistent convention for indicating the unread status. I didn't notice this underline at all.
Moreover, the collapsed thread view still shows the properties of the root message in the conventional way.
Also, there is no thread-level indication for there being flagged messages in the thread. (And no, please don't jump the gun make the text italic to show this, LOL!)
There is too much overloading going on here. The collapsed thread should be regarded as a thread object, and show properties about the thread rather than those of the root message. A design which seems decent would be this:
Basically, all of the visual indicators can simply be a boolean "OR" over the thread.
Comment by kaz on 10 Aug 2010 17:06 UTC
Thunderbird is a pile of crap I don't use.
Thanks for the CSS tip! Looking into the source, I can see how the mail states are incorporated into the document structure, and then visualized with CSS.
So the bolding behavior is achieved trivially:
--- roundcube.orig/skins/default/mail.css 2010-08-10 09:58:22.000000000 -0700
#messagelist tr td.size
This is a good start; but I will refine the patch to get the nice icon behavior also.
Comment by kaz on 10 Aug 2010 17:38 UTC
Uh, it turns out there is already support in the skins for having an icon on the thread parent for denoting that it has unread children. It is the "unreadChildrenIcon", which is left undefined in the default/templates/mail.html. The code already handles this!
So now I have the text bolding, as well as the unread icon behavior. I'm hacking on the flag icon behavior.
Comment by kaz on 10 Aug 2010 20:00 UTC
My above CSS patch is idiotic; take out the background-color: #FFFFFF;. That only screws up the text when the list row is selected (and thus has a red background with white text).
All you want is:
/* thread parent message with unread children */
Comment by kaz on 10 Aug 2010 22:04 UTC
I added a patch which implements the behaviors I wanted (and presumably will work for the person who opened this bug also):
Note 1: I did not patch all of the .css files that work around for various version of explorer, etc.
Comment by sergiocambra on 12 Aug 2010 07:11 UTC
I like this patch because enable skins to set an icon and CSS to collapsed threads with flagged messages as you can do now with collapsed threads with unread messages.
Could you apply it leaving CSS changes out if you don't want them? Although I would move unread children icon below forwarded icon, just before unread icon.
Comment by kaz on 12 Aug 2010 15:09 UTC
Yes. In that case in the default skin the subject will be underlined if the thread has unread children, and will not be colored red if the thread has flagged children.
Also controversial may be that I patched in a choice for the unread children icon, which is left blank, and that I just used the unread message icon. It would be good if we had dedicated icons for this.
You mean if the thread root has been replied/forwarded, you want that icon to show, regardless of unread children? This is the original design and makes sense, because it's more important to know that the thread has unread messages than to know that the root message has been replied/forwarded. The list row for the collapsed thread should convey information about the thread as a whole.
Comment by sergiocambra on 12 Aug 2010 22:22 UTC
Replying to kaz:
I think replied/forwarded can have priority over unread icon because you know thread have unread children because is bold too.
Comment by kaz on 13 Aug 2010 18:34 UTC
I have updated myself to the 0.4 release and rebased this patch.
Comment by kaz on 25 Jul 2013 00:22 UTC
Hey everyone; I upgraded to 0.9.2 this week. If I have time, I will rework the patch to work with the new version.
I haven't tried switching skins, and so I wonder whether the message status icons are fixed, or whether they come from the theme. If they are from the theme, it complicates things slightly (an "unread children" icon will have to be made for each theme; but luckily there are just two in the shipping distro).
The code has probably changed too much for the patches to apply.
please add to the "later" milestone.
All in all, I hope that roundcube moves to a real conversation view as proposed here #499