Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact-Picture and not required fields #4296

Closed
rcubetrac opened this issue Aug 6, 2013 · 5 comments
Closed

Contact-Picture and not required fields #4296

rcubetrac opened this issue Aug 6, 2013 · 5 comments

Comments

@rcubetrac
Copy link

Reported by dennis1993 on 6 Aug 2013 12:54 UTC as Trac ticket #1489274

If I create a new contact in the addressbook and fill in the firstname and lastname.

After that I upload an image. Now I saw two bugs:

  1. If I upload a high image look like this: http://demo.roundcube.net/mail/skins/larry/images/buttons.png the image is not scaled. A max-height and max-width would not be bad. :)
  2. If I click on save after the upload and forgot the email, the image is gone. You can fix it with HTML5 and "required" attribute for email Input and all other required fields.

Thanks a lot!

Migrated-From: http://trac.roundcube.net/ticket/1489274

@rcubetrac
Copy link
Author

Comment by @alecpl on 8 Aug 2013 13:49 UTC

  1. is fixed in 1391f17.

@rcubetrac
Copy link
Author

Comment by @alecpl on 9 Aug 2013 08:16 UTC

  1. fixed in 328876d.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 9 Aug 2013 08:16 UTC

new => closed

@rcubetrac
Copy link
Author

Severity changed by @alecpl on 9 Aug 2013 08:16 UTC

trivial => minor

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 9 Aug 2013 08:16 UTC

0.9.3 => 1.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant